ENH: Allow changing laplacians weights in SyN registration metric #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
==========================================
- Coverage 83.84% 73.88% -9.96%
==========================================
Files 30 30
Lines 2822 2826 +4
Branches 366 291 -75
==========================================
- Hits 2366 2088 -278
- Misses 385 645 +260
- Partials 71 93 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
approved these changes
Mar 26, 2025
Member
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Looks sensible. A quick test to generate the workflow with 0, 0.5 and 1 and check the values in wf.inputs.syn.metric_weight (I think that wokrs) would be useful.
effigies
added a commit
that referenced
this pull request
May 15, 2025
2.13.0 (May 15, 2025) Feature release in the 2.13.x series. This release addresses some longstanding issues with the SyN-SDC workflow, improving the registration quality in adult humans by utilizing a spatial prior, as well as allowing Laplacians to be up- or down-weighted in the cost function, making it more usable across species. Additionally, this release allows for the use of ``EstimatedTotalReadoutTime`` or ``EstimatedEchoSpacing``, or a manually provided fallback ``TotalReadoutTime`` value, permitting the use of SDCFlows on datasets that do not have reliable timing information without introducing incorrect metadata into the datasets. * fix(syn): Re-enable priors respecting ``sd_priors`` argument (#488) * feat: Add workflow arguments for metadata estimates and fallback TRT (#479) * feat(syn): Update totalFieldVarianceInVoxel space based on voxel resolution (#487) * feat(syn): Allow changing laplacians weights in SyN registration metric (#484) * test(syn): Add a test to exercise SyN workflow creation and check parameters (#486)
effigies
added a commit
that referenced
this pull request
May 15, 2025
2.13.0 (May 15, 2025) Feature release in the 2.13.x series. This release addresses some longstanding issues with the SyN-SDC workflow, improving the registration quality in adult humans by utilizing a spatial prior, as well as allowing Laplacians to be up- or down-weighted in the cost function, making it more usable across species. Additionally, this release allows for the use of ``EstimatedTotalReadoutTime`` or ``EstimatedEchoSpacing``, or a manually provided fallback ``TotalReadoutTime`` value, permitting the use of SDCFlows on datasets that do not have reliable timing information without introducing incorrect metadata into the datasets. * fix(syn): Re-enable priors respecting ``sd_priors`` argument (#488) * feat: Add workflow arguments for metadata estimates and fallback TRT (#479) * feat(syn): Update totalFieldVarianceInVoxel space based on voxel resolution (#487) * feat(syn): Allow changing laplacians weights in SyN registration metric (#484) * test(syn): Add a test to exercise SyN workflow creation and check parameters (#486)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.